Timeline for Should code reviewer read user story COAs?
Current License: CC BY-SA 3.0
14 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Apr 25, 2017 at 23:37 | answer | added | Bryan Oakley | timeline score: 2 | |
| Apr 24, 2017 at 15:35 | history | tweeted | twitter.com/StackSQA/status/856531959140548608 | ||
| Apr 24, 2017 at 9:46 | answer | added | Niels van Reijmersdal | timeline score: 5 | |
| Apr 24, 2017 at 9:26 | comment | added | Niels van Reijmersdal | @sneftel My boss has no clue about code-reviews. If he would tell me how to do it I would certainly push back. Listing to your boss is often the worst thing you could do in software development, most bosses have no clue. They should be facilitating, not playing command-and-control. But the question was totally not about his boss. And no ScrumMasters are certainly no bosses, at-least not according to the Scrum guide. | |
| Apr 24, 2017 at 8:57 | vote | accept | Bishnu Rawal | ||
| Apr 24, 2017 at 9:56 | |||||
| Apr 24, 2017 at 5:02 | answer | added | mutt | timeline score: 2 | |
| Apr 23, 2017 at 17:45 | history | migrated | from stackoverflow.com (revisions) | ||
| Apr 21, 2017 at 12:23 | comment | added | slim | Scrum has no stance on code review - it's beyond the scope of what Scrum dictates. | |
| Apr 21, 2017 at 12:20 | comment | added | Bishnu Rawal | Hmm.. If we stop thinking in terms of responsibility, then everybody in team should everything, is that feasible at all? I am not on negative edge like blaming/cursing of peers, i never do that instead I push them to learn things. But to me, it seems scope of code review is not upto functional testing since you have user story queue waiting for you. | |
| Apr 21, 2017 at 12:13 | comment | added | Sneftel | You should stop thinking in terms of "responsibility", at least in the sense of "who gets yelled at if something goes wrong". The reason people do code review is that it helps make code better, not that it shifts the blame. | |
| Apr 21, 2017 at 12:13 | comment | added | Sneftel | Knowing exactly what code is supposed to do is an integral part of reviewing it. You're not just checking the indentation, you're also looking for subtle edge case bugs. | |
| Apr 21, 2017 at 12:09 | comment | added | Bishnu Rawal | Well, I am confused about the specific responsibilities given to code reviewer in scrum world. Of course, Code reviewer should look on code seriously for things mentioned above, but between implementer and QA, this functionality test is not making sense to me. | |
| Apr 21, 2017 at 11:56 | comment | added | Sneftel | The "responsibility of code reviewer" is whatever your boss says it is. Are you suggesting that there's something wrong with looking over what a piece of code is supposed to do before making sure that it does that? | |
| Apr 21, 2017 at 11:52 | history | asked | Bishnu Rawal | CC BY-SA 3.0 |