Skip to main content
Fixed grammar and spelling
Source Link
Bharat Mane
  • 6.8k
  • 11
  • 41
  • 69

We have several part time testers who do both manual testing and test automation.

When I receive a pull request from them, I noticed that I am reviewing their code less strictly and allow morea minor code style or organisationorganization violations to get through. My reasoning is that I know because they work in specific iterations, if I am going to request changes, this would add at least an extra day. Slowing down the turnaround time and increasing the merge conflict probability. Of course, but I do comment/reject if I notice major issues.

How problematic is this situation? Should I take into account that an author of the pull request works part-time or not?

We have several part time testers who do both manual testing and test automation.

When I receive a pull request from them, I noticed that I am reviewing their code less strictly and allow more minor code style or organisation violations to get through. My reasoning is that I know because they work in specific iterations, if I am going to request changes, this would add at least an extra day. Slowing down the turnaround time and increasing the merge conflict probability. Of course, but I do comment/reject if I notice major issues.

How problematic is this situation? Should I take into account that an author of the pull request works part-time or not?

We have several part time testers who do both manual testing and test automation.

When I receive a pull request from them, I noticed that I am reviewing their code less strictly and allow a minor code style or organization violations to get through. My reasoning is that I know because they work in specific iterations, if I am going to request changes, this would add at least an extra day. Slowing down the turnaround time and increasing the merge conflict probability. Of course, but I do comment/reject if I notice major issues.

How problematic is this situation? Should I take into account that an author of the pull request works part-time or not?

We have several part time testers who do both manual testing and test automation.

When I receive a pull request from them, I noticed that I reviewam reviewing their code less strictly and allow more minor code style or organizationorganisation violations to get through. My reasoning is that, I know because they work in specific iterations, I know that, if I am going to request changes, this would add at least an extra day slowing. Slowing down the turnaround time and increasing the merge conflict probability. Of course, but I do comment/reject if I notice major issues.

How problematic is this situation is? Should I take into account that an author of the pull request workworks part-time or not?

We have several part time testers who do both manual testing and test automation.

When I receive a pull request from them, I noticed that I review their code less strictly and allow more minor code style or organization violations to get through. My reasoning is that, because they work in specific iterations, I know that, if I am going to request changes, this would add at least an extra day slowing down the turnaround time and increasing the merge conflict probability. Of course, I do comment/reject if I notice major issues.

How problematic this situation is? Should I take into account that an author of the pull request work part-time or not?

We have several part time testers who do both manual testing and test automation.

When I receive a pull request from them, I noticed that I am reviewing their code less strictly and allow more minor code style or organisation violations to get through. My reasoning is that I know because they work in specific iterations, if I am going to request changes, this would add at least an extra day. Slowing down the turnaround time and increasing the merge conflict probability. Of course, but I do comment/reject if I notice major issues.

How problematic is this situation? Should I take into account that an author of the pull request works part-time or not?

Tweeted twitter.com/StackSQA/status/895431845172662272
edited title
Link
alecxe
  • 11.4k
  • 11
  • 51
  • 107

Code Review and part-time employeesteam members

added 62 characters in body
Source Link
alecxe
  • 11.4k
  • 11
  • 51
  • 107
Loading
Source Link
alecxe
  • 11.4k
  • 11
  • 51
  • 107
Loading