Questions tagged [code-review]

The process of having other team members review code and give suggestions for improvement

Filter by
Sorted by
Tagged with
0
votes
2answers
37 views

Is there a better way to code-review JMeter test-plans?

TLDR - What is the best way to review JMeter Test-Plans stored in a GitHub repo? Currently, the code-review process that my performance-test team uses is somewhat cumbersome and of questionable ...
1
vote
3answers
71 views

Maximum how many lines in a java class file recommended?

Same question I browsed over the internet but not getting the one point answer. I'am working on Automation Selenium using Java. I have created one class lets say ProductDetailsPage.java so I have ...
3
votes
2answers
69 views

How to make the case for code quality in a SAFe environment

SAFe - Scaled Agile Framework for Enterprise. Basically take the agile approach and also have 2 week sprints making up 12 week iterations with planning events once a quarter. Context is a company ...
2
votes
2answers
128 views

How to improve the code quality mindset?

Having Code Review and Pull Requests (for both application and automation code) is great... but in some cases I am seeing a lot of rubber-stamping approvals leading to low quality code. These share ...
5
votes
3answers
194 views

Is it a good idea for a Developer to review a tester's code

Background : Currently working in a firm which follows a practice where the QA's e2e and API automation suites are mandated to be reviewed before being pushed in a CI pipeline. It's a practice that is ...
5
votes
2answers
944 views

What to look for in code reviews / pull requests?

Are there any standard set of things that one should look for during Code Reviews / Pull Requests ? Are there also particular ones for automation vs application code and/or for UI automation (using ...
1
vote
1answer
1k views

SonarQube: Close this “PreparedStatement” in a “finally” clause (dealing with false positives)

Every now and then we come across with some Sonarqube reported issues that seem (at least to us) as false positives. For example when using a Spring JdbcTemplate to execute an update: @Autowired ...
1
vote
1answer
577 views

Correlating assignees with authors in SonarQube

I'm aware that assignees are the effective SonarQube uses that I've created on the platform, but authors come from SCM commit data. The question I need to solve comes from the fact that I'm seeing ...
1
vote
0answers
35 views

Tracking SonarQube users (asignees) issues evolution

Is it possible to get some kind of report of the evolution in time of issues (gross number) assigned to each user of the system? I'd like to track my team members and evaluate them based on wherever ...
2
votes
4answers
541 views

Should QA Engineer read and review code of Web application?

I'm creating a test scenario for new project and I'm wondering if it is a good idea to write Test Cases such as "Access to xxxxxxx/xxxxxx-xxxxxx and verify CSS & HTML properties" has even sense. ...
2
votes
1answer
37 views

Multiple pull request reviewers from different timezones

Our QA team is not a large one, but consists of full or partially remote, full or part time team members which, as it currently stands, live in different countries and in different timezones. We are ...
4
votes
3answers
1k views

Code Review and part-time team members

We have several part time testers who do both manual testing and test automation. When I receive a pull request from them, I noticed that I am reviewing their code less strictly and allow a minor ...
5
votes
1answer
79 views

What is quality javascript in the new world of es6+

Javascript has changed hugely in the last five years with es6 Now we have choices about whether to use let, const or var We can choose whether to use arrow functions to reduce code verbiage Is ...
9
votes
3answers
711 views

How do you know if you are writing high quality tests?

Inspired by Exercises on software testing We can learn to write automated tests and we can learn to do tdd and bdd but what tools / resources / guides are available to tell us if the actual tests we ...
4
votes
3answers
522 views

Should code reviewer read user story COAs?

As I understand, code review is to look for language/framework best practices, uniform conventions, guidelines and optimization paths. A while ago, I was peer reviewing code in scrum team and had some ...
2
votes
5answers
145 views

Advanced Testing Practices

I am a developer who just started a new career in QA, right now I am still learning the basics. While testing a project I see violations of some coding standards (Variable names, Web elements without ...
2
votes
2answers
135 views

How do I convince customers about the importance of code refactoring? [closed]

I affirm working on a software testing project for a customer. Due to a tight budget, I am the only one writing code here. I am thinking of performing code refactoring at the end of this project, ...
2
votes
4answers
267 views

Importance of selenium Framework

I am just finish my selenium code. I'm following page object pattern. My code does not follow any frameworks. My senior who reviewed my code said that:: You need to keep the test data separately. Not ...
7
votes
8answers
2k views

Should testers have access to view developers code? What are pros and cons of this?

I am working as a manual and automation tester for a financial company. Testers in my company don't have access to the source code of our applications, we have limited access rights to our version ...
2
votes
2answers
439 views

Can you review my Selenium test-script? [closed]

Can you check my code and suggest improvements? Here is the scenario .. This is for add folder module package Pages; import org.openqa.selenium.WebDriver; import org.openqa.selenium.WebElement; ...
3
votes
2answers
1k views

How do I make my test code DRY?

My test code has a lot of repetition. First I login to my page then go to the client registration page. Here you can see the repeated code for login. For each page I write first login then current ...
1
vote
1answer
2k views

My code is not working properly

I am working in selenium web driver. I am using selenium 3.0 jar files and firefox version is 49. I am getting a error message. Can anybody tell me the solution ? package Hello; import org.openqa....
2
votes
1answer
307 views

Can you suggest any tool to review an existing code base effectively?

We have a large part in our code base that was never reviewed and has a lot of flaws. As every tool I know only allows code review by pull request, is there any tool to review an existing code base, ...
1
vote
1answer
126 views

Can you check this POM design Pattern? [closed]

I had written my first Page Object Pattern. Can anybody to check this code and tell me the feedback? What mistakes are that i have made? I want to correct it? I am Verifying to access login page and ...
2
votes
1answer
127 views

Can you check this code? [closed]

I worked in selenium for 3 months. I had written some code. In my company I am the only tester. Nobody knows about the testing. But I couldn't find a solution for is it my code is correct or not. I ...
2
votes
2answers
400 views

tool that can be automated for page testing, full page screenshots and code analysis and compare with previous tests [closed]

I've been tasked with locating a software package or single application that can be used to automate the following tasks related to testing our website(s), both english and non-english. run automated ...
6
votes
6answers
2k views

Is there an industry standard or good practices for the code review activity?

An SDLC explains how an item of software can be defined, modeled, developed, tested, released and supported. The SDLC is split into any number of phases, depending on the methodology used (Waterfall, ...